Skip to content

feat(dashboards): Add All Dashboards tab and rename existing to Custom#114904

Merged
DominikB2014 merged 9 commits intomasterfrom
dominikbuszowiecki/dain-1637-rename-all-dashboards-tab-to-custom-dashboards
May 6, 2026
Merged

feat(dashboards): Add All Dashboards tab and rename existing to Custom#114904
DominikB2014 merged 9 commits intomasterfrom
dominikbuszowiecki/dain-1637-rename-all-dashboards-tab-to-custom-dashboards

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

@DominikB2014 DominikB2014 commented May 5, 2026

Adds all dashboards and custom dashboards option when prebuilt dashboards are enabled, custom dashboards is retained as the default.

image

…ustom

When `dashboards-prebuilt-insights-dashboards` is enabled, the secondary
navigation now shows three tabs:

- All Dashboards (`?filter=all`): combined view of custom + prebuilt
- Custom Dashboards: the existing no-filter view, renamed from "All
  Dashboards"
- Sentry Built (`?filter=onlyPrebuilt`): unchanged

The primary sidebar still lands on Custom Dashboards (the no-filter URL)
to preserve existing behavior; the new All tab is opt-in via the
secondary nav.

DAIN-1637
@DominikB2014 DominikB2014 requested review from a team as code owners May 5, 2026 19:31
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 5, 2026

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.44%

…f prebuilt

The vast majority of orgs have the prebuilt dashboards feature enabled,
so the per-org label split adds noise without helping the rare
non-prebuilt case.
…b enum

Replace the ad-hoc isOnlyPrebuilt/isAllDashboards booleans with a single
DashboardsTab state derived from the URL filter, plus mapping tables for
the page title and API query params. The mutually exclusive boolean
states made the filter logic harder to follow and easier to break with a
new tab.
Add an "All Dashboards" entry that links to ?filter=all when prebuilt
dashboards are enabled, and rename the no-filter entry to "Custom
Dashboards" so it matches the secondary nav after the recent split.
Copy link
Copy Markdown
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits. This might work a bit better if we had separate URLs for these filters, but not a big deal 👍🏻

Comment thread static/app/components/commandPalette/ui/commandPaletteGlobalActions.tsx Outdated
… off

When `dashboards-prebuilt-insights-dashboards` is disabled, there's no
sibling "Sentry Built" tab to contrast against, so "Custom Dashboards"
loses its meaning. Fall back to "All Dashboards" for that case in the
page title, secondary nav link, and command palette entry. Tests now
enable the prebuilt flag so they exercise the rename branch.
@DominikB2014 DominikB2014 enabled auto-merge (squash) May 6, 2026 15:30
@DominikB2014 DominikB2014 merged commit c740a3b into master May 6, 2026
71 of 73 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-1637-rename-all-dashboards-tab-to-custom-dashboards branch May 6, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants